feat: use junit5 platform in our tests#1187
Merged
Merged
Conversation
rubenporras
reviewed
Oct 15, 2025
| @@ -52,6 +52,8 @@ | |||
| <unit id="org.mockito" version="2.23.0.v20200310-1642"/> | |||
| <unit id="org.hamcrest" version="2.2.0.v20210711-0821"/> | |||
| <unit id="org.junit" version="4.13.2.v20211018-1956"/> | |||
Member
There was a problem hiding this comment.
should we not remove now the old junit unit?
Collaborator
Author
There was a problem hiding this comment.
we cant, it is still required to run the vintage engine
Collaborator
Author
There was a problem hiding this comment.
we can remove it as we gradually convert our tests to native junit5
Member
There was a problem hiding this comment.
I have been looking at it and I understand it now. Can we still change a bit the target file to pull a newer junit 5? You can use
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/tools/orbit/simrel/maven-osgi/2025-09"/>
<unit id="junit-jupiter-api" version="5.13.4"/>
<unit id="junit-vintage-engine" version="5.13.4"/>
</location>
rubenporras
requested changes
Oct 15, 2025
Member
rubenporras
left a comment
rubenporras
left a comment
There was a problem hiding this comment.
should we not remove now the old junit unit?
use junit-vintage-engine to support junit4 tests
markdomeng
force-pushed
the
junit5vintage2
branch
from
de506ae to
38918bc
Compare
rubenporras
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use junit-vintage-engine to support junit4 tests