Skip to content

feat: Migrate cat.ddk.xtext.ui.test to Junit5 #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markdomeng merged 3 commits into from
Oct 23, 2025
Merged

feat: Migrate cat.ddk.xtext.ui.test to Junit5 #1191

markdomeng merged 3 commits into from
Oct 23, 2025

Conversation

@markdomeng
Copy link
Collaborator

@markdomeng markdomeng commented Oct 17, 2025

removed junit4 dependencies
removed dependency to DiscerningSuite. Once we migrate the DiscerningSuite to Junit5 we can use it again here

rubenporras
rubenporras previously approved these changes Oct 17, 2025
View reviewed changes
@markdomeng @MarkDomingo4458
feat: Migrate cat.ddk.xtext.ui.test to Junit5
635ecdc 
removed junit4 dependencies
removed dependency to DiscerningSuite. Once we migrate the
DiscerningSuite to Junit5 we can use it again here
rubenporras
rubenporras reviewed Oct 18, 2025
View reviewed changes
com.avaloq.tools.ddk.xtext.ui.test/src/com/avaloq/tools/ddk/xtext/ui/test/XtextUiTestSuite.java Outdated
import org.junit.platform.suite.api.SelectClasses;
import org.junit.platform.suite.api.Suite;

import com.avaloq.tools.ddk.test.core.junit.runners.DiscerningSuite;
Copy link
Member

@rubenporras rubenporras Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this import needs to be removed.

rubenporras
rubenporras requested changes Oct 18, 2025
View reviewed changes
Copy link
Member

@rubenporras rubenporras left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the unused import.

Then, PMD gives several warnings on other classes, could you address this?

Finally, I think it would be good if you could approve and rebase on #1192.

@markdomeng
Copy link
Collaborator Author

markdomeng commented Oct 21, 2025

You need to remove the unused import.

Then, PMD gives several warnings on other classes, could you address this?

Finally, I think it would be good if you could approve and rebase on #1192.

they look fals positive:
[INFO] �[1m--- �[0;32mpmd:3.28.0:check�[m �[1m(default-cli)�[m @ �[36mcom.avaloq.tools.ddk.xtext.ui.test�[0;1m ---�[m
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorRunTest:59 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorRunTest:99 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor should not explicitly throw java.lang.Exception.
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorTest:30 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorTest:41 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor should not explicitly throw java.lang.Exception.
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.templates.ResourceNameTemplateVariableResolverTest:37 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.templates.SimpleEnumTemplateVariableResolverTest:36 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorRunTest:59 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorRunTest:99 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor should not explicitly throw java.lang.Exception.
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorTest:30 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorTest:41 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor should not explicitly throw java.lang.Exception.
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.templates.ResourceNameTemplateVariableResolverTest:37 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.templates.SimpleEnumTemplateVariableResolverTest:36 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[INFO]

example:
The first warning is issued on the CLASS declaration, this is not right. java class should be public.
the second one is issued on setup() but in some classes it is not issued..

I think pMD is just not working correctly yest with Junit5 ?

joaodinissf
joaodinissf requested changes Oct 21, 2025
View reviewed changes
@MarkDomingo4458
feat: Migrate cat.ddk.xtext.ui.test to Junit5
915d4c1 
removed junit4 dependencies
removed dependency to DiscerningSuite. Once we migrate the
DiscerningSuite to Junit5 we can use it again here
@joaodinissf
Copy link
Collaborator

joaodinissf commented Oct 22, 2025

LGTM after fixing the small syntax issue I commented above. @rubenporras ?

@markdomeng @joaodinissf
Update com.avaloq.tools.ddk.xtext.ui.test/src/com/avaloq/tools/ddk/xt…
1682f7a 
…ext/ui/test/XtextUiTestSuite.java


Fix formatting

Co-authored-by: João Dinis Ferreira <hello@joaof.eu>
@rubenporras
Copy link
Member

rubenporras commented Oct 23, 2025

LGTM as well

@markdomeng markdomeng merged commit 991d16a into dsldevkit:master Oct 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaodinissf joaodinissf joaodinissf approved these changes

@rubenporras rubenporras rubenporras approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markdomeng @joaodinissf @rubenporras @MarkDomingo4458