feat: Migrate com.avaloq.tools.ddk.xtext.checkcfg.core.test to Junit5#1217
Merged
Conversation
markdomeng
force-pushed
the
checkcorej5
branch
from
0132b1e to
1828d2b
Compare
rubenporras
approved these changes
Nov 10, 2025
| // CHECKSTYLE:CHECK-ON Visibility | ||
| // @RegisterExtension | ||
| // // CHECKSTYLE:CHECK-OFF Visibility MethodRules cannot be private | ||
| // public final LoggingRule watchman = LoggingRule.getInstance(); |
Member
There was a problem hiding this comment.
why do we uncomment all this lines? Is it possible that you forgot to remove the comments after some testing?
Collaborator
Author
There was a problem hiding this comment.
yes you are right. i commented it when I was debugging, and accidentally pushed without removing . thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.