docs: clarify test aggregator pattern in AGENTS.md#1317
Merged
joaodinissf merged 1 commit intoMay 6, 2026
Conversation
Replace the imprecise "tests are disabled by default and activated only in test bundles" line with an accurate description of the aggregator pattern: `xtext.test/AllTests.java` is a JUnit 5 @suite that pulls in ~14 per-module *TestSuite classes, running all tests in a single Eclipse OSGi runtime. Document why flipping <skip>false</skip> in other .test modules fails and shouldn't be done. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
252c146 to
492119d
Compare
rubenporras
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdTesting section to accurately describe the test aggregator pattern:com.avaloq.tools.ddk.xtext.test/src/.../AllTests.javais a JUnit 5@Suitethat pulls in ~14 per-module*TestSuiteclasses, running all tests in a single Eclipse OSGi runtime.<skip>true</skip>default ontycho-surefire-plugininddk-parent/pom.xmlis correct behavior, not a bug.<skip>false</skip>in individual.testmodules fails ("Cannot resolve dependencies") — those bundles don't carry the tycho-surefire configuration needed to spin up their own test runtime.Test plan
AGENTS.mdrenders correctly on GitHub.🤖 Generated with Claude Code