build: prevent unused imports#1363
Merged
Merged
Conversation
rubenporras
requested changes
May 26, 2026
| <property name="allowInSwitchCase" value="true"/> | ||
| </module> | ||
| <module name="AvoidStarImport"/> | ||
| <module name="UnusedImports"/> |
The maven-checkstyle UnusedImports check parses Javadoc to track
{@link} references, so malformed Javadoc tags abort the check. Three
files escaped the broader cleanup in this branch:
- CheckValidator.java: @see {@link X} -> @see X
- CheckCfgValidator.java: @see {@link X} -> @see X
- TemplateVariableResolverTestHelper.java: stray @ in
{@link TemplateVariableResolver@} typo, plus three
@throws {@link X}\n X} multilines normalized to single-line
@throws X.
Verified locally on macOS: mvn -T 3C clean verify checkstyle:check
pmd:check pmd:cpd-check spotbugs:check -f ddk-parent/pom.xml passes
with 357 tests, 0 checkstyle / PMD / SpotBugs violations.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
unusedImports
branch
from
1337b62 to
82e0ac4
Compare
rubenporras
approved these changes
May 26, 2026
auto-merge was automatically disabled
May 26, 2026 17:56
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the
unusedImportsstaging branch to master: enables the checkstyleUnusedImportsrule and cleans up the Javadoc parse errors it surfaces.Verified locally on macOS:
mvn -T 3C clean verify checkstyle:check pmd:check pmd:cpd-check spotbugs:check -f ddk-parent/pom.xmlpasses with 357 tests, 0 checkstyle / PMD / SpotBugs violations.— opened by Claude at João's request