fix: null-safe fragment access in DefaultFragmentWithOverride.checkConfiguration#1386
Merged
joaodinissf merged 1 commit intoJun 1, 2026
Conversation
…nfiguration defaultFragment and overrideFragment are documented as optionally null, and generate() and initialize() both access them null-safely (?.). checkConfiguration dereferenced them unconditionally, NPEing whenever either is null. Use ?. to match the rest of the class. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rubenporras
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultFragmentWithOverride.defaultFragment/overrideFragmentare documented as optionally null ("or nothing if it is null"), andgenerate()andinitialize()access them null-safely with?..checkConfiguration()dereferenced them unconditionally → NPE whenever either is null. Added?.to match the rest of the class.Found by a repo-wide inconsistency sweep.
🤖 Generated with Claude Code