Skip to content

Fix: Comparison can be timezone aware #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Comparison can be timezone aware #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e491dad
push with minimal changes
eco-JoshuaJackson Nov 3, 2025
b73553e
change to safe_yaml
eco-JoshuaJackson Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions gha_cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import logging
import os
from collections import namedtuple
from datetime import datetime
from datetime import datetime, timezone
from typing import Optional, List, Set, Dict, Union, Any, Tuple

import click
Expand Down Expand Up @@ -83,7 +83,11 @@ def get_action_latest_release(self, uses_tag_value: str) -> Optional[str]:
logging.debug(f"Found in cache {action_name}: {latest_release}")
if _is_sha(current_version):
logging.debug(f"Current version for {action_name} is a SHA: {current_version}, checking whether latest release is newer")
if latest_release[1] > datetime.now():
now = datetime.now(timezone.utc)
release_time = latest_release[1]
if release_time.tzinfo is None:
release_time = release_time.replace(tzinfo=timezone.utc)
if release_time > now:
return latest_release[0]
return latest_release[0] if self._compare_versions(latest_release[0], current_version) > 0 else None

Expand Down Expand Up @@ -126,7 +130,7 @@ def list_full_paths(path: str) -> set[str]:

def get_workflow_action_names(self, repo_name: str, workflow_path: str) -> Set[str]:
workflow_content = self._get_workflow_file_content(repo_name, workflow_path)
workflow = yaml.load(workflow_content, Loader=yaml.CLoader)
workflow = yaml.safe_load(workflow_content)
res = set()
for job in workflow.get("jobs", dict()).values():
for step in job.get("steps", list()):
Expand All @@ -149,7 +153,7 @@ def get_repo_actions_latest(self, repo_name: str) -> Dict[str, List[ActionVersio
if "@" not in action:
continue
all_actions_no_version.add(action.split("@")[0])
logging.info(f"Found {len(all_actions_no_version)} actions in workflows: {", ".join(all_actions_no_version)}")
logging.info(f"Found {len(all_actions_no_version)} actions in workflows: {', '.join(all_actions_no_version)}")
for path, actions in actions_per_path.items():
for action in actions:
if "@" not in action:
Expand All @@ -165,7 +169,7 @@ def get_repo_workflow_names(self, repo_name: str) -> Dict[str, str]:
for path in workflow_paths:
try:
content = self._get_workflow_file_content(repo_name, path)
yaml_content = yaml.load(content, Loader=yaml.CLoader)
yaml_content = yaml.safe_load(content)
res[path] = yaml_content.get("name", path)
except FileNotFoundError as ex:
logging.warning(ex)
Expand Down