Skip to content

Fix docker SSH commands#1771

Merged
un-def merged 1 commit intomasterfrom
issue_1769_fix_container_provisioning
Oct 3, 2024
Merged

Fix docker SSH commands#1771
un-def merged 1 commit intomasterfrom
issue_1769_fix_container_provisioning

Conversation

@un-def
Copy link
Copy Markdown
Collaborator

@un-def un-def commented Oct 2, 2024

  • Properly detect package manager
  • Report unsupported distribution
  • Unset/restore ld.so variables

Fixes: #1769

@un-def
Fix docker SSH commands
0628d03 
* Properly detect package manager
* Report unsupported distribution
* Unset/restore ld.so variables

Fixes: #1769
@un-def
Copy link
Copy Markdown
Collaborator Author

un-def commented Oct 2, 2024

Unsupported distribution (e.g., Alpine)

before:

Screenshot_2024-10-02_15-08-20

after:

Screenshot_2024-10-02_14-08-58

TGI image with LD_PRELOAD

run spec:

type: task
image: ghcr.io/huggingface/text-generation-inference@sha256:2984316ccbeefdf0c67e7e5e5a1c08b68929e2986169505e0f353d07c2746e59
commands:
  - echo LD_LIBRARY_PATH=$LD_LIBRARY_PATH
  - echo LD_PRELOAD=$LD_PRELOAD

before:

Screenshot_2024-10-02_14-00-34

after:

Screenshot_2024-10-02_15-06-00

@un-def un-def requested a review from r4victor October 2, 2024 16:30
@un-def un-def merged commit 9f2ae01 into master Oct 3, 2024
@un-def un-def deleted the issue_1769_fix_container_provisioning branch October 3, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r4victor r4victor r4victor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Run provisioning failed with some images when openssh-server is installed

2 participants

@un-def @r4victor