Run container as --privileged if DSTACK_DOCKER_PRIVILEGED#1821
Merged
un-def merged 1 commit intodstackai:masterfrom Oct 15, 2024
Merged
Run container as --privileged if DSTACK_DOCKER_PRIVILEGED#1821un-def merged 1 commit intodstackai:masterfrom
un-def merged 1 commit intodstackai:masterfrom
Conversation
This is needed to run Docker-in-Docker. I'm *guessing* the env vars passed from the `env:` section at the root of the task yaml make it to the initialization of `dstack-shim`, but please let me know if not! Fixes dstackai#1820
Collaborator
Unfortunately, this doesn't work that way, but the new variable may still useful nonetheless (esp. for SSH fleets). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to run Docker-in-Docker.
I'm guessing the env vars passed from the
env:section at the root of the task yaml make it to the initialization ofdstack-shim, but please let me know if not!Fixes #1820