Skip to content

Show run error on the run page in the UI #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olgenn merged 1 commit into from
Oct 14, 2024
Merged

Show run error on the run page in the UI #1829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/pages/Runs/List/Preferences/consts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export const DEFAULT_PREFERENCES: CollectionPreferencesProps.Preferences = {
{ id: 'price', visible: true },
{ id: 'submitted_at', visible: true },
{ id: 'status', visible: true },
{ id: 'error', visible: true },
{ id: 'cost', visible: true },
// hidden by default
{ id: 'project', visible: false },
Expand Down
1 change: 1 addition & 0 deletions frontend/src/pages/Runs/List/Preferences/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export const Preferences: React.FC = () => {
{ id: 'price', label: t('projects.run.price') },
{ id: 'submitted_at', label: t('projects.run.submitted_at') },
{ id: 'status', label: t('projects.run.status') },
{ id: 'error', label: t('projects.run.error') },
{ id: 'cost', label: t('projects.run.cost') },
// hidden by default
{ id: 'project', label: t('projects.run.project') },
Expand Down
5 changes: 5 additions & 0 deletions frontend/src/pages/Runs/List/hooks/useColumnsDefinitions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ export const useColumnsDefinitions = () => {
</StatusIndicator>
),
},
{
id: 'error',
header: t('projects.run.error'),
cell: (item: IRun) => item.error ?? '-',
},
{
id: 'cost',
header: `${t('projects.run.cost')}`,
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/types/run.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ declare interface IRun {
project_name: string,
user: string,
submitted_at: string,
status: TJobStatus
status: TJobStatus,
error?: string
jobs: IJob[],
run_spec: IRunSpec,
latest_job_submission?: IJobSubmission
Expand Down