Skip to content

[shim] Don't cache GpuVendor in global var #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
un-def merged 1 commit into from
Oct 16, 2024
Merged

[shim] Don't cache GpuVendor in global var #1845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions runner/internal/shim/gpu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,14 @@ type GpuInfo struct {
Vram int // MiB
}

var gpuVendor GpuVendor

func GetGpuVendor() GpuVendor {
if gpuVendor != "" {
return gpuVendor
}
if _, err := os.Stat("/dev/kfd"); !errors.Is(err, os.ErrNotExist) {
gpuVendor = Amd
} else if _, err := exec.LookPath("nvidia-smi"); err == nil {
gpuVendor = Nvidia
} else {
gpuVendor = NoVendor
return Amd
}
if _, err := exec.LookPath("nvidia-smi"); err == nil {
return Nvidia
}
return gpuVendor
return NoVendor
}

func GetGpuInfo() []GpuInfo {
Expand Down