Skip to content

Allow to customize AMIs used by AWS backend#1920

Merged
un-def merged 2 commits intomasterfrom
issue_1913_aws_custom_amis
Oct 31, 2024
Merged

Allow to customize AMIs used by AWS backend#1920
un-def merged 2 commits intomasterfrom
issue_1913_aws_custom_amis

Conversation

@un-def
Copy link
Copy Markdown
Collaborator

@un-def un-def commented Oct 30, 2024

Closes: #1913

@un-def un-def requested review from jvstme and r4victor October 30, 2024 15:10
* SSH server listening on port 22
* `user` with passwordless sudo access
* Docker is installed
* (For NVIDIA instances) NVIDIA/CUDA drivers are installed
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And nvidia-container-toolkit

Comment on lines +23 to +26
image = image_config.nvidia if cuda else image_config.cpu
if image is None:
logger.warning("%s image not configured", "nvidia" if cuda else "cpu")
raise ComputeResourceNotFoundError()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) Btw, alternatively we could filter out the offers that don't have an image configured. This way, we won't waste provisioning attempts and will show more realistic run plans. That would especially be useful for Azure, e.g. to filter out A10 offers if the GRID image is not configured.

Yet the current implementation provides more insight into why the offers aren't working, so I'm not sure which alternative is better and we can stick with the current one.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for now, I would stick to the current implementation, as I assume that the setup where custom AMIs are used, but not all (currently, all = only two) kinds are configured, is rare. In the future, if there are more kinds of images, we could revisit the logic.

@un-def un-def merged commit 6959dab into master Oct 31, 2024
@un-def un-def deleted the issue_1913_aws_custom_amis branch October 31, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: [AWS] Allow to specify AMI identifiers in the backend config

3 participants