Skip to content

[dind] Update start-dockerd script#1928

Merged
un-def merged 1 commit intomasterfrom
issue_1914_dind_fix_supervisor_detection
Nov 1, 2024
Merged

[dind] Update start-dockerd script#1928
un-def merged 1 commit intomasterfrom
issue_1914_dind_fix_supervisor_detection

Conversation

@un-def
Copy link
Copy Markdown
Collaborator

@un-def un-def commented Oct 31, 2024

  • Fix supervisord running state detection
  • Show supervisord log if supervisorctl fails
  • Check if dockerd log exists before rm
  • Replace magic number exit statuses with constants
  • add is_verbose/is_true helpers

Fixes: #1914

* Fix supervisord running state detection
* Show supervisord log if supervisorctl fails
* Check if dockerd log exists before `rm`
* Replace magic number exit statuses with constants
* add `is_verbose`/`is_true` helpers

Fixes: #1914
@un-def un-def requested a review from jvstme October 31, 2024 08:05
@un-def un-def merged commit b0c182e into master Nov 1, 2024
@un-def un-def deleted the issue_1914_dind_fix_supervisor_detection branch November 1, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [dind] start-dockerd incorrectly detects whether supervisord is started

2 participants