Skip to content

Fix VolumeModel.user not loaded for volume detach #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 1 commit into from
Nov 7, 2024
Merged

Fix VolumeModel.user not loaded for volume detach #1970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dstack/_internal/server/services/jobs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
RunSpec,
)
from dstack._internal.core.services.ssh.tunnel import SSHTunnel, ports_to_forwarded_sockets
from dstack._internal.server.models import InstanceModel, JobModel, ProjectModel
from dstack._internal.server.models import InstanceModel, JobModel, ProjectModel, VolumeModel
from dstack._internal.server.services.backends import get_project_backend_by_type
from dstack._internal.server.services.jobs.configurators.base import JobConfigurator
from dstack._internal.server.services.jobs.configurators.dev import DevEnvironmentJobConfigurator
Expand Down Expand Up @@ -221,7 +221,7 @@ async def process_terminating_job(session: AsyncSession, job_model: JobModel):
.where(InstanceModel.id == job_model.used_instance_id)
.options(
selectinload(InstanceModel.project).joinedload(ProjectModel.backends),
selectinload(InstanceModel.volumes),
selectinload(InstanceModel.volumes).joinedload(VolumeModel.user),
selectinload(InstanceModel.job),
)
.with_for_update()
Expand Down