Allow specifying gateway in service configurations#1972
Merged
Conversation
jvstme
force-pushed
the
issue_1595_gateway_in_run_conf
branch
from
82ec253 to
6199140
Compare
un-def
reviewed
Nov 7, 2024
| return v | ||
|
|
||
| @validator("gateway") | ||
| def validate_gateway( |
Collaborator
There was a problem hiding this comment.
Is this for the sake of human-readable error message? Otherwise, Optional[Union[Literal[False], str]] would do the same validation automatically (didn't check though)
Collaborator
Author
There was a problem hiding this comment.
I tried Union[Literal[False], str] first, but this way true passes validation and is converted to "true", which is not expected
un-def
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1595