[UX]: live table when provisioning dstack configuration runs #1978#2036
Merged
jvstme merged 3 commits intodstackai:masterfrom Nov 26, 2024
Merged
[UX]: live table when provisioning dstack configuration runs #1978#2036jvstme merged 3 commits intodstackai:masterfrom
jvstme merged 3 commits intodstackai:masterfrom
Conversation
- Remove redundant instructions when reattaching - Add empty lines before and after the table - Keep updating the table while the run is `terminating`. This provides faster feedback and more details for troubleshooting - When provisioning finishes, update the table one more time so that it shows the relevant run status, e.g. `running`
jvstme
reviewed
Nov 26, 2024
Comment on lines
+228
to
+230
| break | ||
| time.sleep(LIVE_TABLE_PROVISION_INTERVAL_SECS) | ||
| run.refresh() |
Collaborator
There was a problem hiding this comment.
These lines seem to be redundant:
breakwill never be reached afterexit(1)on line 227time.sleepis redundant because the decision to reattach is already made on line 216run.refreshis redundant because the run was already refreshed on line 213
Collaborator
|
@Tob-iee, thanks for reopening the PR. This version looks and works great. I've made some minor tweaks and will merge the PR soon. Thanks for contributing! |
superprat
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Dec 20, 2024
…#1978 (dstackai#2036) Co-authored-by: Jvst Me <git@jvst.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1951 @jvstme, yeah, you are right I didn't reflect the changes after merging dstackai:master into my branch. I re-opened it. Can you have another look? it should work fine