Fix returning metrics from deleted runs#2038
Merged
Conversation
This commit fixes the bug when
`/api/metrics/job/{run_name}` would randomly
return metrics from a deleted run instead of the
active run with the same name.
It also includes a small optimization to only
fetch the latest job submission from the database
instead of filtering in runtime.
un-def
approved these changes
Nov 28, 2024
superprat
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Dec 20, 2024
This commit fixes the bug when
`/api/metrics/job/{run_name}` would randomly
return metrics from a deleted run instead of the
active run with the same name.
It also includes a small optimization to only
fetch the latest job submission from the database
instead of filtering in runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the bug when
/api/metrics/job/{run_name}would randomlyreturn metrics from a deleted run instead of the
active run with the same name.
It also includes a small optimization to only
fetch the latest job submission from the database
instead of filtering in runtime.
Fixes #2037