Conversation
For all configuration types: - Show a spinner while provisioning. - Show a non-verbose live table to save screen space. - After provisioning, show a final render of the table with absolute times, not relative. This allows the table to stay relevant if the user looks at it later. - In case of errors, show a verbose table in the final render to provide more details for troubleshooting. - In case of errors, show a highlighted error description. For runs: - Merge the backend+region and resources+spot columns to save screen space and for consistency with other configuration types. - Show the replica and job number on the same line for better readability and consistency with `dstack stats`. - For single-job runs, show the status of the job, not the run. This allows the `pulling` status to be visible. For fleets: - Wait for the `terminating`->`terminated` transition before quitting so that the table shows a relevant final status. Misc: - Remove unused code: the `configuration` column in the runs table and timestamp arguments to `pretty_date`.
r4victor
approved these changes
Dec 2, 2024
superprat
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Dec 20, 2024
For all configuration types: - Show a spinner while provisioning. - Show a non-verbose live table to save screen space. - After provisioning, show a final render of the table with absolute times, not relative. This allows the table to stay relevant if the user looks at it later. - In case of errors, show a verbose table in the final render to provide more details for troubleshooting. - In case of errors, show a highlighted error description. For runs: - Merge the backend+region and resources+spot columns to save screen space and for consistency with other configuration types. - Show the replica and job number on the same line for better readability and consistency with `dstack stats`. - For single-job runs, show the status of the job, not the run. This allows the `pulling` status to be visible. For fleets: - Wait for the `terminating`->`terminated` transition before quitting so that the table shows a relevant final status. Misc: - Remove unused code: the `configuration` column in the runs table and timestamp arguments to `pretty_date`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all configuration types:
For runs:
dstack stats.pullingstatus to be visible.For fleets:
terminating->terminatedtransition before quitting so that the table shows a relevant final status.Misc:
configurationcolumn in the runs table and timestamp arguments topretty_date.This PR is not part of an issue, but it follows the changes from #1951 and is based on feedback from the team.