Optimize gateway startup and service update time#2153
Merged
Conversation
Avoid running certbot if the certificate exists. This greatly reduces the gateway startup time when many services or entrypoints are being re-registered. Running certbot can take 3-4 seconds, even if the certificate already exists and there is nothing to do. Certificate renewal is not an issue as it is done by certbot's built-in systemd timer.
un-def
approved these changes
Dec 27, 2024
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Feb 9, 2025
Avoid running certbot if the certificate exists. This greatly reduces the gateway startup time when many services or entrypoints are being re-registered. Running certbot can take 3-4 seconds, even if the certificate already exists and there is nothing to do. Certificate renewal is not an issue as it is done by certbot's built-in systemd timer.
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 4, 2025
Avoid running certbot if the certificate exists. This greatly reduces the gateway startup time when many services or entrypoints are being re-registered. Running certbot can take 3-4 seconds, even if the certificate already exists and there is nothing to do. Certificate renewal is not an issue as it is done by certbot's built-in systemd timer.
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 5, 2025
Avoid running certbot if the certificate exists. This greatly reduces the gateway startup time when many services or entrypoints are being re-registered. Running certbot can take 3-4 seconds, even if the certificate already exists and there is nothing to do. Certificate renewal is not an issue as it is done by certbot's built-in systemd timer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid running certbot if the certificate exists.
This greatly reduces the gateway startup time when
many services or entrypoints are being
re-registered. Running certbot can take 3-4
seconds, even if the certificate already exists
and there is nothing to do.
Certificate renewal is not an issue as it is done
by certbot's built-in systemd timer.
#1595