Skip to content

Conversation

@r4victor
Copy link
Collaborator

@r4victor r4victor commented Dec 30, 2024

Part of #2150

The PR changes /api/runs/list behavior to include deleted runs by default. If only_active: true is set, deleted runs are filtered out as before because deleted runs always have finished statuses.

The change also affects the CLI: dstack ps -a now includes deleted (overridden) runs as well:

✗ dstack ps -a
 NAME                  BACKEND       RESOURCES    PRICE     STATUS      SUBMITTED   
 my-dev                aws           2xCPU, 8GB,  $0.0447   running     3 mins ago  
                       (eu-west-1)   100.0GB                                        
                                     (disk),                                        
                                     SPOT                                           
 my-dev                aws           2xCPU, 8GB,  $0.0447   terminated  4 mins ago  
                       (eu-west-1)   100.0GB                                        
                                     (disk),                                        
                                     SPOT                                                            

Before merging this PR, the UI should be update to show run details page for deleted runs based on id (now different runs within a project can have the same name because deleted runs are returned).

@github-actions
Copy link

This PR is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Jan 14, 2025
@peterschmidt85
Copy link
Contributor

@r4victor is the task pending on @olgenn ?

@r4victor
Copy link
Collaborator Author

@peterschmidt85, yes: #2150

@github-actions
Copy link

This PR is stale because it has been open for 14 days with no activity.

@r4victor r4victor merged commit fec1085 into master Feb 10, 2025
5 checks passed
@r4victor r4victor deleted the issue_2150_list_deleted_runs branch February 10, 2025 10:14
pranitnaik43 pushed a commit to bahaal-tech/dstack that referenced this pull request Mar 4, 2025
* Return deleted runs in /api/runs/list

* Fix typo
pranitnaik43 pushed a commit to bahaal-tech/dstack that referenced this pull request Mar 5, 2025
* Return deleted runs in /api/runs/list

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants