Skip to content

Return deleted runs in /api/runs/list #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 3 commits into from
Feb 10, 2025
Merged

Return deleted runs in /api/runs/list #2158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c59f775
Return deleted runs in /api/runs/list
r4victor Dec 30, 2024
b9127e8
Merge branch 'master' into issue_2150_list_deleted_runs
r4victor Feb 10, 2025
e10a0ab
Fix typo
r4victor Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/dstack/_internal/server/routers/runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ async def list_runs(
"""
Returns all runs visible to user sorted by descending `submitted_at`.
`project_name`, `repo_id`, `username`, and `only_active` can be specified as filters.
Setting `only_active` to `true` excludes finished runs and deleted runs.
Specifying `repo_id` without `project_name` returns no runs.

The results are paginated. To get the next page, pass `submitted_at` and `id` of
Expand Down
3 changes: 2 additions & 1 deletion src/dstack/_internal/server/services/runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ async def list_projects_run_models(
limit: int,
ascending: bool,
) -> List[RunModel]:
filters = [RunModel.deleted == False, RunModel.project_id.in_(p.id for p in projects)]
filters = []
filters.append(RunModel.project_id.in_(p.id for p in projects))
if repo is not None:
filters.append(RunModel.repo_id == repo.id)
if runs_user is not None:
Expand Down