Fix caching offers with GPU requirements#2210
Merged
Conversation
Use `Requirements.json` instead of `Requirements.dict`+`json.dumps`, which fails on enums. Also remove `sort_keys=True`, which seems to be redundant. > field order is preserved by .dict() and .json() > etc. https://docs.pydantic.dev/1.10/usage/models/#field-ordering
jvstme
requested review from
r4victor and
un-def
and removed request for
r4victor
un-def
approved these changes
Jan 23, 2025
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Feb 9, 2025
Use `Requirements.json` instead of `Requirements.dict`+`json.dumps`, which fails on enums. Also remove `sort_keys=True`, which seems to be redundant. > field order is preserved by .dict() and .json() > etc. https://docs.pydantic.dev/1.10/usage/models/#field-ordering
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 4, 2025
Use `Requirements.json` instead of `Requirements.dict`+`json.dumps`, which fails on enums. Also remove `sort_keys=True`, which seems to be redundant. > field order is preserved by .dict() and .json() > etc. https://docs.pydantic.dev/1.10/usage/models/#field-ordering
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 5, 2025
Use `Requirements.json` instead of `Requirements.dict`+`json.dumps`, which fails on enums. Also remove `sort_keys=True`, which seems to be redundant. > field order is preserved by .dict() and .json() > etc. https://docs.pydantic.dev/1.10/usage/models/#field-ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Requirements.jsoninstead ofRequirements.dict+json.dumps, which fails on enums.Also remove
sort_keys=True, which seems to be redundant.Fixes #2208