Do not wait in VerdaCompute.create_instance#3723
Merged
Conversation
Previously, `VerdaCompute.create_instance` would block for up to 3 minutes while the SDK was waiting for the instance to leave the `ORDERED` status. This could hurt performance (the database connection is blocked while waiting) and reliability (server restarts or exceptions during the wait cause the instance to be orphaned). Use the newly introduced Verda SDK option to avoid the wait in `create_instance()`, so that it is performed by subsequent `update_provisioning_data()` calls instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
VerdaCompute.create_instancewouldblock for up to 3 minutes while the SDK was
waiting for the instance to leave the
ORDEREDstatus. This could hurt performance (the database
connection is blocked while waiting) and
reliability (server restarts or exceptions during
the wait cause the instance to be orphaned).
Use the newly introduced Verda SDK option to avoid
the wait in
create_instance(), so that it isperformed by subsequent
update_provisioning_data()calls instead.