Skip to content

[Internal] Improve warning message in ServerConfigManager.apply_config() #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
un-def merged 2 commits into from
Apr 23, 2026
Merged

[Internal] Improve warning message in ServerConfigManager.apply_config() #3804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1245f00
[Internal] Improve warning message in `ServerConfigManager.apply_conf…
un-def Apr 21, 2026
fcf9303
Replace ApplyAction with plain strings
un-def Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions src/dstack/_internal/server/services/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,20 +164,25 @@ async def _apply_project_config(
comparable_backend_config = current_source_backend_config or current_backend_config
if backend_config == comparable_backend_config:
continue
# current_backend_config may be None if backend exists
# but it's config is invalid (e.g. cannot be decrypted).
# Update backend in this case.
if current_backend_config is None and not backend_exists:
apply_action = "create"
apply_func = backends_services.create_backend
else:
apply_action = "update"
apply_func = backends_services.update_backend
try:
# current_backend_config may be None if backend exists
# but it's config is invalid (e.g. cannot be decrypted).
# Update backend in this case.
if current_backend_config is None and not backend_exists:
await backends_services.create_backend(
session=session, project=project, config=backend_config
)
else:
await backends_services.update_backend(
session=session, project=project, config=backend_config
)
await apply_func(session=session, project=project, config=backend_config)
except Exception as e:
logger.warning("Failed to configure backend %s: %s", backend_config.type, e)
logger.warning(
"Failed to %s backend %s in project %s: %s",
apply_action,
backend_config.type,
project.name,
e,
)
await delete_backends_safe(
session=session,
project=project,
Expand Down
Loading