Support nvidia dynamo#3868
Merged
Merged
Conversation
added 2 commits
May 8, 2026 22:31
jvstme
reviewed
May 11, 2026
jvstme
reviewed
May 11, 2026
jvstme
reviewed
May 13, 2026
Comment on lines
+30
to
+32
| Using an enum (rather than empty-dict sentinels) means callers can rely | ||
| on either `is` or `==` to compare — both yield correct, unambiguous | ||
| results — and stray dicts from elsewhere can never accidentally match. |
Collaborator
There was a problem hiding this comment.
(nit) I think this comparison between enums and empty dicts won't make much sense to a reader who hasn't seen the previous implementation with empty dicts.
Overall, many comments and docstrings in the PR look a bit too verbose and redundant to me. I'd only keep minimal comments that add important context which is not otherwise clear from the naming or the implementation
added 2 commits
May 14, 2026 15:16
jvstme
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service Configuration example