Properly escape artifact paths#391
Merged
Merged
Conversation
peterschmidt85
pushed a commit
that referenced
this pull request
May 15, 2023
* Implement default escaper * Escape paths in JobHead and TagHead keys
peterschmidt85
added a commit
that referenced
this pull request
May 18, 2023
* - [Docs] Rework the documentation to focus it on use-cases #386 * Add untracked files to repo_diff (#388) * - [Docs] Fixed logo URLs in the `README.md` file * Make add_patch simple and robust to binary files (#392) * Make add_patch simple and robust to binary files * Do not include empty diffs * Properly escape artifact paths (#391) * Implement default escaper * Escape paths in JobHead and TagHead keys * Mount git credentials into the container (#395) * Replace backend with hub_client in providers * Pass home_dir to runner, mount git credentials into the container * Update Hub API for run details UI (#394) * Add hub endpoints for managing runs * Implement heirarchical artifact listing * Fix repo init error message * Fix gcp file uploading * Include hub logs in pytest output * Fix getting filesize for older Python * Fix process termination * Prohibit SSH key with passphrase for repo credentials (#397) * Stop reading hub stderr in tests to avoid deadlock (#398) * Disable git credentials helper for ls-remote (#399) * Disable git credentials helper for ls-remote * Test whether repo is public or not without gcm * Pre 0.8.1 fixes (#401) * Replace local_runner with dash in runs table * Pad interruption message with empty lines * - [CLI] Updated the version of `openvscode-server` in the `code` provider to `1.78.1` * Generate default SSH keypair (#407) * Remove local repo warning * Generate ssh key by default * Adjust tests for automatic keypair generation * Handle NoSuchProcess in tests (#409) * - [Docs] Rework the documentation to focus it on use-cases #386 (the second batch) * - [Docs] Rework the documentation to focus it on use-cases #386 (the third batch) * Support Azure backend (#411) * create template for cloud image for Azure * add image for cuda * kick github to do image building * implement barebones of azure to make config and init (requires initial secret management) * implement barebones of azure storage to start run command * implement barebones of azure compute with choosing instance's type * drop some code about creating image from instance type * set minimal servions for azure sdk packages * hack resource allocation for reusing, execute dstack-runner * reach termination stage in dstack run by eliminating NotImplementedError * save * save * save * implement basic backend, few storage methods (runner) * put stub on logging place * mirror a code from python about secret * port python-split style of regex * make runner to do a job to the end (upload dir has bug) * rename images for align with aws * fix uploaddir * upload local runner with azure backend in building image process * refactor config into GCP-style * fix reconfiguring azure (read azure config to use it as deefault) * write down instruction to allocate resources * set permissions for virtual machine * change config structure for runner after cli * return back corp preferences in image building * deallocate resources * implement shutdown, clean up resources * resolve data race in launching * drop some code into storage to support ls * make _get_instance_type working again * Fix azure runner file renaming * Reorder azure backend methods * Remove unnecessary azure compute logic * Run user_data script * Terminate azure instances from cli * Implement azure storage upload and download * Delete azure vm from runner * Implement azure secrets * Support job dependencies for azure * Implement azure logs * Build azure image * Fix azure image building * Get azure prod image * Test azure image publish * Test publishing azure image to all regions * Test publishing azure image to all recommended regions * Test publishing azure image to all recommended regions * Test azure image publishing after build * Test azure image publishing after build * Test azure image publishing after build * WIP azure config * Turn off GA for azure * Implement azure config in cli * Supported azure config in runner * Run go mod tidy * Rebuild azure images * Make runner work remotely * Rebuild azure images * Generate azure vm password * Support creating azure storage account * Grant roles to logged in user * Add more supported azure locations * Filter out azure VM types and support GPUs * Move dstack azure resource to westeurope * Publish azure images as separate image definitions * Delete vm disk on vm deletion * Specify docker image version for azure image build * Rebuild azure images * Support ssh for azure * Fix azure images resource group * Use unique azure image sku * Support azure spot instances * Update go mod * Remove files after merge * Support Azure configuration via API * Trigger azure image build * Fix Azure backend after merge * Fix Azure logging * Trigger azure image build * Fix azure artifacts listing * Implement azure auth via client secret * Specify azure dependencies as extras * Trigger azure image build * SSH as ubuntu user on azure * Move backends dependencies to extras * Support azure public images * Do not publish staging azure images * Remove publish_azure_image.yml workflow * Fix azure secret key encoding in runner --------- Co-authored-by: Stepan Bakshayev <step2back@gmail.com> * - [Docs] Rework the documentation to focus it on use-cases #386 (the forth batch) --------- Co-authored-by: Egor Sklyarov <egor.sklyarov.ru@gmail.com> Co-authored-by: Victor Skvortsov <vds003@gmail.com> Co-authored-by: Stepan Bakshayev <step2back@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #314
escape_headandunescape_headJobHeadandTagHeadfilenames