Handle repo patch with non-UTF8 sequences#3918
Open
un-def wants to merge 1 commit into
Open
Conversation
Git text diff is not actually text in the usual sense -- it may contain any nonprintable bytes. But since we send patches as files (multipart/form-data), not as JSON strings, we don't need to decode them at all. In addition, the missing --binary flag was added. Without this flag, modified binary files were effectively excluded from the patch with "Binary files a and b differ". Fixes: #3880
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git text diff is not actually text in the usual sense -- it may contain any nonprintable bytes.
But since we send patches as files (multipart/form-data), not as JSON strings, we don't need to decode them at all.
In addition, the missing --binary flag was added.
Without this flag, modified binary files were effectively excluded from the patch with "Binary files a and b differ".
Fixes: #3880