Skip to content

Conversation

@Egor-S
Copy link
Contributor

@Egor-S Egor-S commented Jun 26, 2023

Closes #456

  • Warn user if git diff takes longer than 5 seconds
    • Suggest updating .gitignore
  • Gracefully exit from git diff on Ctrl+C
  • Do not serialize repo_diff
    • It accelerates get_run_plan for large diffs

@Egor-S
Copy link
Contributor Author

Egor-S commented Jun 26, 2023

Ctrl+C may be ignored during subprocess deletion. However, it is not very likely and doesn't affect the consistency

Exception ignored in: <function Git.AutoInterrupt.__del__ at 0x10e8988c0>
Traceback (most recent call last):
  File "/Users/egors/dstack/envs/p37/lib/python3.7/site-packages/git/cmd.py", line 567, in __del__
    self._terminate()

@Egor-S Egor-S merged commit af24759 into master Jun 26, 2023
@Egor-S Egor-S deleted the issue_456_too_long_diff branch June 29, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show a warning if the Git diff is taking more than X seconds

2 participants