Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions hub/src/locale/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@
"backend_type_description": "Select a backend type",
"members_empty_message_title": "No members",
"members_empty_message_text": "Select project's members",
"delete_project_confirm_title": "Delete project",
"delete_project_confirm_message": "Are you sure you want to delete this project?",
"cli": "CLI",
"aws": {
"authorization": "Authorization",
Expand All @@ -99,7 +101,10 @@
"s3_bucket_name_description": "Select an S3 bucket to store artifacts",
"ec2_subnet_id": "Subnet",
"ec2_subnet_id_description": "Select a subnet to run workflows in",
"ec2_subnet_id_placeholder": "Not selected"
"ec2_subnet_id_placeholder": "Not selected",
"extra_regions": "Additional regions",
"extra_regions_description": "Select additional regions to run workflows",
"extra_regions_placeholder": "Select regions"
},
"azure" : {
"authorization": "Authorization",
Expand Down Expand Up @@ -291,7 +296,7 @@
"refresh_token_success_notification": "Token rotating is successful",
"refresh_token_error_notification": "Token rotating error",
"refresh_token_confirm_title": "Rotate token",
"refresh_token_confirm_message": "Do you sure want to rotate token?",
"refresh_token_confirm_message": "Are you sure you want to rotate token?",
"refresh_token_button_label": "Rotate",
"validation": {
"user_name_format": "Only letters, numbers, - or _"
Expand All @@ -315,7 +320,7 @@
},
"confirm_dialog": {
"title": "Confirm delete",
"message": "Do you sure want to delete?"
"message": "Are you sure you want to delete?"
}
}

12 changes: 11 additions & 1 deletion hub/src/pages/Project/Details/Settings/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ export const ProjectSettings: React.FC = () => {
const renderAwsBackendDetails = (): React.ReactNode => {
if (!data) return null;

const extraRegions = data.backend.extra_regions?.join(', ');

return (
<ColumnLayout columns={4} variant="text-grid">
<div>
Expand All @@ -100,7 +102,15 @@ export const ProjectSettings: React.FC = () => {

<div>
<Box variant="awsui-key-label">{t('projects.edit.aws.ec2_subnet_id')}</Box>
<div>{data.backend.ec2_subnet_id}</div>
<div>{data.backend.ec2_subnet_id || '-'}</div>
</div>

<div>
<Box variant="awsui-key-label">{t('projects.edit.aws.extra_regions')}</Box>

<div style={{ whiteSpace: 'nowrap', textOverflow: 'ellipsis', overflow: 'hidden' }} title={extraRegions}>
{extraRegions || '-'}
</div>
</div>
</ColumnLayout>
);
Expand Down
9 changes: 8 additions & 1 deletion hub/src/pages/Project/Details/index.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, { useMemo, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { Outlet, useLocation, useNavigate, useParams } from 'react-router-dom';
import Box from '@cloudscape-design/components/box';

import { Button, ButtonProps, ConfirmationDialog, ContentLayout, DetailsHeader } from 'components';

Expand Down Expand Up @@ -82,7 +83,13 @@ export const ProjectDetails: React.FC = () => {
<Outlet />
</ContentLayout>

<ConfirmationDialog visible={showDeleteConfirm} onDiscard={toggleDeleteConfirm} onConfirm={deleteUserHandler} />
<ConfirmationDialog
visible={showDeleteConfirm}
onDiscard={toggleDeleteConfirm}
onConfirm={deleteUserHandler}
title={t('projects.edit.delete_project_confirm_title')}
content={<Box variant="span">{t('projects.edit.delete_project_confirm_message')}</Box>}
/>
</>
);
};
2 changes: 1 addition & 1 deletion hub/src/pages/Project/EditBackend/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const ProjectEditBackend: React.FC = () => {
]);

const onCancelHandler = () => {
navigate(ROUTES.PROJECT.DETAILS.REPOSITORIES.FORMAT(paramProjectName));
navigate(ROUTES.PROJECT.DETAILS.SETTINGS.FORMAT(paramProjectName));
};

const onSubmitHandler = async (data: Partial<IProject>): Promise<IProject> => {
Expand Down
13 changes: 13 additions & 0 deletions hub/src/pages/Project/Form/AWS/constants.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export const FIELD_NAMES = {
REGION_NAME: 'region_name',
S3_BUCKET_NAME: 's3_bucket_name',
EC2_SUBNET_ID: 'ec2_subnet_id',
EXTRA_REGIONS: 'extra_regions',
};

export const CREDENTIALS_HELP = {
Expand Down Expand Up @@ -79,3 +80,15 @@ export const SUBNET_HELP = {
</>
),
};

export const ADDITIONAL_REGIONS_HELP = {
header: <h2>Additional regions</h2>,
body: (
<>
<p>
dstack will try to provision the instance in additional regions if the primary region has no capacity.{' '}
Specifying additional regions increases the chances of provisioning spot instances.
</p>
</>
),
};
36 changes: 34 additions & 2 deletions hub/src/pages/Project/Form/AWS/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,25 @@ import { useFormContext } from 'react-hook-form';
import { useTranslation } from 'react-i18next';
import { debounce } from 'lodash';

import { FormInput, FormS3BucketSelector, FormSelect, FormSelectOptions, InfoLink, SpaceBetween, Spinner } from 'components';
import {
FormInput,
FormMultiselect,
FormMultiselectOptions,
FormS3BucketSelector,
FormSelect,
FormSelectOptions,
InfoLink,
SpaceBetween,
Spinner,
} from 'components';

import { useHelpPanel, useNotifications } from 'hooks';
import { isRequestFormErrors2, isRequestFormFieldError } from 'libs';
import { useBackendValuesMutation } from 'services/project';
import { AWSCredentialTypeEnum } from 'types';

import useIsMounted from '../../../../hooks/useIsMounted';
import { BUCKET_HELP, CREDENTIALS_HELP, FIELD_NAMES, REGION_HELP, SUBNET_HELP } from './constants';
import { ADDITIONAL_REGIONS_HELP, BUCKET_HELP, CREDENTIALS_HELP, FIELD_NAMES, REGION_HELP, SUBNET_HELP } from './constants';

import { IProps } from './types';

Expand All @@ -25,6 +35,7 @@ export const AWSBackend: React.FC<IProps> = ({ loading }) => {
const [regions, setRegions] = useState<FormSelectOptions>([]);
const [buckets, setBuckets] = useState<TAwsBucket[]>([]);
const [subnets, setSubnets] = useState<FormSelectOptions>([]);
const [extraRegions, setExtraRegions] = useState<FormMultiselectOptions>([]);
const [availableDefaultCredentials, setAvailableDefaultCredentials] = useState<null | boolean>(null);
const lastUpdatedField = useRef<string | null>(null);
const isFirstRender = useRef<boolean>(true);
Expand Down Expand Up @@ -105,6 +116,14 @@ export const AWSBackend: React.FC<IProps> = ({ loading }) => {
if (response.ec2_subnet_id?.selected !== undefined) {
setValue(`backend.${FIELD_NAMES.EC2_SUBNET_ID}`, response.ec2_subnet_id.selected ?? '');
}

if (response.extra_regions?.values) {
setExtraRegions(response.extra_regions.values);
}

if (response.extra_regions?.selected !== undefined) {
setValue(`backend.${FIELD_NAMES.EXTRA_REGIONS}`, response.extra_regions.selected);
}
} catch (errorResponse) {
console.log('fetch backends values error:', errorResponse);
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
Expand Down Expand Up @@ -262,6 +281,19 @@ export const AWSBackend: React.FC<IProps> = ({ loading }) => {
options={subnets}
secondaryControl={renderSpinner()}
/>

<FormMultiselect
info={<InfoLink onFollow={() => openHelpPanel(ADDITIONAL_REGIONS_HELP)} />}
label={t('projects.edit.aws.extra_regions')}
description={t('projects.edit.aws.extra_regions_description')}
placeholder={t('projects.edit.aws.extra_regions_placeholder')}
control={control}
name={`backend.${FIELD_NAMES.EXTRA_REGIONS}`}
onChange={getOnChangeSelectField(FIELD_NAMES.EXTRA_REGIONS)}
disabled={getDisabledByFieldName(FIELD_NAMES.EXTRA_REGIONS)}
secondaryControl={renderSpinner()}
options={extraRegions}
/>
</SpaceBetween>
);
};
5 changes: 5 additions & 0 deletions hub/src/types/project.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ declare interface IProjectAwsBackendValues {
selected?: string | null,
values: { value: string, label: string}[]
} | null,
extra_regions: {
selected?: string[] | null,
values: { value: string, label: string}[]
} | null,
}

declare interface IProjectAzureBackendValues {
Expand Down Expand Up @@ -107,6 +111,7 @@ declare interface TProjectBackendAWS {
region_name: string,
s3_bucket_name: string,
ec2_subnet_id: string | null,
extra_regions: string[],
}

enum AzureCredentialTypeEnum {
Expand Down