Skip to content

Conversation

@dswah
Copy link
Owner

@dswah dswah commented Sep 12, 2018

  • makes setting term attributes more consistent so:
gam = GAM(terms='auto')
gam.n_splines = 5

doesnt fail and is equivalent to

gam = GAM(s(0, n_splines=5))
  • term parameters should be easier to broadcast:
GAM(terms=s(0) + s(1), n_splines=10)

is equivalent to

GAM(terms=s(0, n_splines=10) + s(1, n_splines=10))

@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #199 into master will decrease coverage by 0.25%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   94.92%   94.67%   -0.26%     
==========================================
  Files          22       22              
  Lines        3016     3002      -14     
==========================================
- Hits         2863     2842      -21     
- Misses        153      160       +7
Impacted Files Coverage Δ
pygam/tests/test_GAM_methods.py 100% <ø> (ø) ⬆️
pygam/pygam.py 94.43% <96.15%> (ø) ⬆️
pygam/core.py 90.62% <0%> (-9.38%) ⬇️
pygam/terms.py 93.41% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d7fac...69ca31a. Read the comment docs.

@dswah dswah merged commit 75701bc into master Sep 13, 2018
@dswah dswah deleted the easy-plural branch September 13, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants