Skip to content

Conversation

@dswah
Copy link
Owner

@dswah dswah commented Nov 20, 2025

Fixes #370

@dswah dswah changed the title Logliklihood Loglikelihood Nov 20, 2025
@fkiraly fkiraly changed the title Loglikelihood [BUG] fix incorrect scale parameter in Distribution Nov 22, 2025
@fkiraly fkiraly added the bug label Nov 22, 2025
@dswah
Copy link
Owner Author

dswah commented Nov 27, 2025

@serjisa @jamesdeeel
Could one of you give a review of the fixes here?

@serjisa
Copy link

serjisa commented Nov 27, 2025

Hi!

Yeah, quick check shows that now pyGAM gives reasonable log-likelihood estimations that are consistent with statsmodels: https://colab.research.google.com/drive/1gYm4FES72bClRzRu4G9Jnv0xeLdD0sNW?usp=sharing

Thank you a lot!

@dswah dswah merged commit adfe850 into main Nov 27, 2025
16 of 17 checks passed
@dswah dswah deleted the logliklihood branch November 27, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Scale Parameter in Distribution

4 participants