Skip to content

Feature #3269 GenEnsProd EAS config#3279

Open
georgemccabe wants to merge 2 commits intodevelopfrom
feature_3269_eas
Open

Feature #3269 GenEnsProd EAS config#3279
georgemccabe wants to merge 2 commits intodevelopfrom
feature_3269_eas

Conversation

@georgemccabe
Copy link
Copy Markdown
Collaborator

@georgemccabe georgemccabe commented Apr 15, 2026

Pull Request Testing

  • Describe testing already performed for these changes:

Added new unit tests to demonstrate setting of new config variables.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review code changes -- consider testing using changes from MET PR dtcenter/MET#3369

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 4/20/2026.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-13.0.0 milestone Apr 15, 2026
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-13.0 Development Apr 15, 2026
@georgemccabe georgemccabe linked an issue Apr 15, 2026 that may be closed by this pull request
23 tasks
@georgemccabe georgemccabe moved this from 🩺 Needs Triage to 🔎 In review in METplus-13.0 Development Apr 15, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 15, 2026

Coverage Report for CI Build 24471624129

Coverage increased (+0.001%) to 92.054%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 10471
Covered Lines: 9639
Line Coverage: 92.05%
Coverage Strength: 1.84 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In review

Development

Successfully merging this pull request may close these issues.

Enhancement: Update the GenEnsProd wrapper to support EAS enhancements

2 participants