Skip to content

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Aug 15, 2017

It seems like the ELEMNT BOLT writes messages without application_id
set. Check this in add_dev_data_id(message) and store None in
DEV_TYPES[dev_data_index]['application_id'].

@pR0Ps
Copy link
Collaborator

pR0Ps commented Aug 21, 2017

Thanks, this looks like a pretty straightforward fix. Would you be able to also include a small example fit file that causes this issue (and a test that loads it as well)?

EDIT: This will fix #35
EDIT2: The example files provided in this issue exhibit the problem (ask permission if you intend to add them instead of your own files).

flokli added 2 commits August 21, 2017 11:23
as seen on ELEMNT BOLT (firmware version WB09-1507)
…t application_id

It seems like the ELEMNT bolt writes messages without application_id
set. In that case, store None there.

fixes dtcooper#35.
@flokli flokli closed this Aug 21, 2017
@flokli flokli deleted the no-application-id branch August 21, 2017 09:27
@flokli flokli restored the no-application-id branch August 21, 2017 09:27
@flokli flokli reopened this Aug 21, 2017
@flokli flokli force-pushed the no-application-id branch from 73582c2 to bb54ac8 Compare August 21, 2017 09:29
@flokli
Copy link
Contributor Author

flokli commented Aug 21, 2017

@pR0Ps I added a small example file and a test. Also, please have a look at #37, it contains some fixes for the testsuite (could also add travis integration in a follow-up, if you like)

@pR0Ps pR0Ps merged commit de90d9a into dtcooper:master Aug 21, 2017
@flokli flokli deleted the no-application-id branch August 23, 2017 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants