Skip to content

records: allow developer_data_id messages without set application_id #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2017
Merged

records: allow developer_data_id messages without set application_id #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d6a748
add test file for files without application id inside developer data
flokli Aug 21, 2017
bb54ac8
records: add_dev_data_id: allow developer_data_id messages without se…
flokli Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fitparse/records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,10 @@ def parse_string(string):
def add_dev_data_id(message):
global DEV_TYPES
dev_data_index = message.get('developer_data_index').raw_value
application_id = message.get('application_id').raw_value
if message.get('application_id'):
application_id = message.get('application_id').raw_value
else:
application_id = None

# Note that nothing in the spec says overwriting an existing type is invalid
DEV_TYPES[dev_data_index] = {'dev_data_index': dev_data_index, 'application_id': application_id, 'fields': {}}
Expand Down
Binary file added tests/files/elemnt-bolt-no-application-id-inside-developer-data-id.fit
View file
Open in desktop
Binary file not shown.
5 changes: 5 additions & 0 deletions tests/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,11 @@ def test_fileish_types(self):
with FitFile(io.BytesIO(open(testfile("Settings.fit"), 'rb').read())):
pass

def test_elemnt_bolt_developer_data_id_without_application_id(self):
"""Test that a file without application id set inside developer_data_id is parsed
(as seen on ELEMNT BOLT with firmware version WB09-1507)"""
FitFile(testfile('elemnt-bolt-no-application-id-inside-developer-data-id.fit')).parse()

# TODO:
# * Test Processors:
# - process_type_<>, process_field_<>, process_units_<>, process_message_<>
Expand Down