Ignore proc-macro feature on wasm-target#469
Merged
dtolnay merged 1 commit intodtolnay:masterfrom Aug 12, 2018
lukaslueg:master
Merged
Ignore proc-macro feature on wasm-target#469dtolnay merged 1 commit intodtolnay:masterfrom lukaslueg:master
dtolnay merged 1 commit intodtolnay:masterfrom
lukaslueg:master
Conversation
dtolnay
approved these changes
Aug 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes the proc-macro feature to be ignored for wasm-targets where proc-macro is not available. Currently, if a crate is to be built on wasm that depends on
syn, the proc-macro feature from an actual proc-macro leaks into the build-environment ofsyn, causing the build to fail.This patch enables me to build (and run) my crate on wasm-targets.
I'd be nice if this could be bumped into a 0.14 release. This is a concerted effort with proc-macro2,
syn,quoteand stdweb; all of which need patching to compile on wasm.