forked from datafold/data-diff
-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
P0-criticalShip-blocking, fix immediatelyShip-blocking, fix immediatelybugSomething isn't workingSomething isn't workingciCI/CD pipelineCI/CD pipelinetestingTest coverage and infrastructureTest coverage and infrastructuretriage
Description
Problem
Both CI workflows (ci.yml:53-56, ci_full.yml:44-47) and the Makefile silently --ignore three test files:
test_database_types.py(818 lines) — the most comprehensive type-coverage test exercising every driver's type handling. For a cross-database diff tool, this is arguably the most important test file.test_main.py(249 lines) — tests the CLI entry pointtest_dbt_config_validators.py(33 lines) — likely uses Pydantic v1parse_objAPI
No comment explains why these are excluded. CI shows green while skipping critical coverage.
Scope
- Run each excluded test file locally to identify failures
- Fix the failures (likely Pydantic v1→v2 migration for validators, possible import issues for others)
- Re-enable in CI, or add explicit
pytest.mark.skipwith documented reason - Remove
--ignoreflags fromci.yml,ci_full.yml, andMakefile
Key Files
.github/workflows/ci.yml:53-56.github/workflows/ci_full.yml:44-47Makefiletests/test_database_types.pytests/test_main.pytests/test_dbt_config_validators.py
Acceptance Criteria
- All three test files either pass in CI or have documented skip reasons
-
--ignoreflags removed from CI workflows and Makefile - CI remains green
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P0-criticalShip-blocking, fix immediatelyShip-blocking, fix immediatelybugSomething isn't workingSomething isn't workingciCI/CD pipelineCI/CD pipelinetestingTest coverage and infrastructureTest coverage and infrastructuretriage