CI: skip build/install steps for docs-only PRs#25
Merged
Conversation
The "build" job is a required status check, so it must still run and report on every PR (a paths-ignore trigger would leave it stuck pending forever for README-only changes). Instead, diff against the PR base to detect whether any of the paths that actually affect the build changed, and skip npm ci/npm run build when they didn't - mirrors Cloudflare's "Build watch paths" list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildjob in ci.yml is a required status check, so a plainpaths-ignoretrigger would leave PRs that only touch README/docs stuck with an unfulfilled required check forever.src/,wrangler.toml,package.json,package-lock.json,build.mjs- same list as Cloudflare's "Build watch paths"), and skips thenpm ci/npm run buildsteps when they didn't.Test plan
.github/workflows/ci.yml, which isn't in the watch list, so thebuildcheck should complete quickly without annpm ci/npm run buildstep actually running - confirm in the Actions log.src/**change should still run the full install + build.