Skip to content

Reorder fields and add comment + add TODO #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

Reorder fields and add comment + add TODO #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion extension/httpfs/include/httpfs_client.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ struct HTTPFSParams : public HTTPParams {
bool enable_server_cert_verification = DEFAULT_ENABLE_SERVER_CERT_VERIFICATION;
bool enable_curl_server_cert_verification = true;
idx_t hf_max_per_page = DEFAULT_HF_MAX_PER_PAGE;
string user_agent = {""};
string ca_cert_file;
string bearer_token;
bool unsafe_disable_etag_checks {false};
shared_ptr<HTTPState> state;
string user_agent = {""};
// Additional fields needs to be appended at the end and need to be propagated to duckdb-wasm
// TODO: make this unnecessary
};

class HTTPFSUtil : public HTTPUtil {
Expand Down
Loading