Skip to content

Fix header inclusion #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2025
Merged

Fix header inclusion #139

merged 1 commit into from
Sep 27, 2025

Conversation

@dentiny
Copy link
Contributor

@dentiny dentiny commented Sep 27, 2025

Header files shouldn't be included in the namespace, otherwise all symbols inside are namespace scoped.

@dentiny dentiny mentioned this pull request Sep 27, 2025
Open
@carlopi carlopi changed the base branch from main to v1.4-andium September 27, 2025 07:44
@carlopi carlopi changed the base branch from v1.4-andium to main September 27, 2025 07:45
@carlopi carlopi merged commit 6b683b1 into duckdb:main Sep 27, 2025
23 checks passed
@carlopi
Copy link
Collaborator

carlopi commented Sep 27, 2025

Thanks for correcting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dentiny @carlopi