Do not allow to cancel other running statements#245
Merged
staticlibs merged 1 commit intoduckdb:mainfrom Jun 5, 2025
Merged
Conversation
staticlibs
force-pushed
the
cancel_statement_check
branch
from
afa10ff to
9e25c62
Compare
`Statement#cancel()` call works on connection level. So currently it is well possible to run query in one statement, and then interrupt this query calling cancel on another statement. This change adds a check that cancellation can only be performed if the query on current statement is still running. Otherwise `stmt.cancel()` call is a no-op. Testing: new test added that checks that other statement cannot be cancelled.
staticlibs
force-pushed
the
cancel_statement_check
branch
from
9e25c62 to
44264d0
Compare
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Jun 15, 2025
This is a backport of the PR duckdb#245 to `v1.3-ossivalis` stable branch. `Statement#cancel()` call works on connection level. So currently it is well possible to run query in one statement, and then interrupt this query calling cancel on another statement. This change adds a check that cancellation can only be performed if the query on current statement is still running. Otherwise `stmt.cancel()` call is a no-op. Testing: new test added that checks that other statement cannot be cancelled.
staticlibs
added a commit
that referenced
this pull request
Jun 15, 2025
This is a backport of the PR #245 to `v1.3-ossivalis` stable branch. `Statement#cancel()` call works on connection level. So currently it is well possible to run query in one statement, and then interrupt this query calling cancel on another statement. This change adds a check that cancellation can only be performed if the query on current statement is still running. Otherwise `stmt.cancel()` call is a no-op. Testing: new test added that checks that other statement cannot be cancelled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statement#cancel()call works on connection level. So currently it is well possible to run query in one statement, and then interrupt this query calling cancel on another statement.This change adds a check that cancellation can only be performed if the query on current statement is still running. Otherwise
stmt.cancel()call is a no-op.Testing: new test added that checks that other statement cannot be cancelled.