Appender: fix buffer size for nested STRUCTs (1.4) #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of the PR duckdb#439 to `v1.4-andium` stable branch. This change fixes the buffer size calculation for `STRUCT`s nested inside `LIST`s and for `MAP`s. It also fixes the validity mask size calculation for these cases. Testing: additional tests added with longer `MAP`s (to check nested `STRUCT`s) and with `NULL` values (to check validity masks). Fix: duckdb#437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of the PR #439 to
v1.4-andiumstable branch.This change fixes the buffer size calculation for
STRUCTs nested insideLISTs and forMAPs. It also fixes the validity mask size calculation for these cases.Testing: additional tests added with longer
MAPs (to check nestedSTRUCTs) and withNULLvalues (to check validity masks).Fix: #437