Skip to content

fix: don't use external buffers on platforms without support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix: don't use external buffers on platforms without support #3

merged 2 commits into from
Oct 6, 2023

Conversation

@Mause
Copy link
Contributor

@Mause Mause commented Oct 5, 2023

@Mause Mause requested a review from hannes October 5, 2023 02:42
@Mytherin
Copy link
Contributor

Mytherin commented Oct 5, 2023

Thanks for the PR! LGTM - is the change to the Makefile intentional?

@Mause
Copy link
Contributor Author

Mause commented Oct 5, 2023

Thanks for the PR! LGTM - is the change to the Makefile intentional?

Yep, it's intentional. Without it, running make debug will first build a copy slowly, then another in parallel

@hannes hannes merged commit 249288e into duckdb:main Oct 6, 2023
@hannes
Copy link
Member

hannes commented Oct 6, 2023

Thanks !

@Mause Mause deleted the external-buffers branch October 9, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannes hannes Awaiting requested review from hannes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Iterating arrowIPCStream crashes electron

3 participants

@Mause @Mytherin @hannes