Use connection pool from common repo#427
Merged
staticlibs merged 1 commit intoduckdb:mainfrom Apr 3, 2026
Merged
Conversation
This PR changes the connection pool implementation to use the one from the [database-connector](https://github.com/duckdb/database-connector) repository. The user-facing functionality stays the same with the following changes: - default pool size is changed from `64` to `max(num_cpus, 8)` - `pg_connection_cache` setting now can be used to disable the pool, but not to re-enable it; `pg_connection_limit` setting should be set to positive number to enable back the pool that was disabled. - when the pool is enabled and all connection slots are already used, the request to get the connection from the pool will try to acquire the connection from the pool for 30 seconds before throwing an error. More pool settings are planned to be exposed in subsequent PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the connection pool implementation to use the one from the database-connector repository.
The user-facing functionality stays the same with the following changes:
64tomax(num_cpus, 8)pg_connection_cachesetting now can be used to disable the pool, but not to re-enable it;pg_connection_limitsetting should be set to positive number to enable back the pool that was disabled.More pool settings are planned to be exposed in subsequent PRs.