Support connection URI in SECRETs#459
Merged
Merged
Conversation
This PR adds support for specifying the [connection URI](https://www.postgresql.org/docs/18/libpq-connect.html?utm_source=chatgpt.com#LIBPQ-CONNSTRING-URIS) instead of connection options in the `SECRET` definitions, example: ```sql CREATE OR REPLACE SECRET my_secret ( TYPE POSTGRES, URI 'postgresql://user1:pwd1@localhost:5432/mydb1?target_session_attrs=any&application_name=myapp' ); ATTACH '' AS p1 (TYPE POSTGRES, secret my_secret); ``` When `URI` is specified in a `SECRET`, the `ATTACH` path must be empty, and no other connection options can be specified. See duckdb#458 for supported connection options. Fixes: duckdb#307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying the
connection URI instead of connection options in the
SECRETdefinitions, example:When
URIis specified in aSECRET, theATTACHpath must be empty, and no other connection options can be specified.See #458 for supported connection options.
Fixes: #307