Skip to content

Fix #26. #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 5, 2025
Merged

Fix #26. #31

merged 7 commits into from
Sep 5, 2025

Conversation

@dsevilla
Copy link
Contributor

@dsevilla dsevilla commented Sep 4, 2025

This hopefully fixes #26:

  • Changed the type of the file_globs parameter of from_parquet and read_parquet in connection_methods.json.
  • Added the generation of @overload functions in the generation wrappers python code.

dsevilla and others added 6 commits September 3, 2025 14:21
@dsevilla
Update from_parquet and read_parquet method signatures.
cbf7b99 
from_parquet and read_parquet are incorrectly described as receiving just a str parameter where they allow to receive also a list of files/globs as a list of str.

This fixes duckdb#26, although more work is needed because this file is auto-generated.
@dsevilla
Revert "Update from_parquet and read_parquet method signatures."
b72c6e1 
This reverts commit cbf7b99.
@dsevilla
Fix for duckdb#26:
b76a66a 
- Changed the type of the file_globs parameter of from_parquet and read_parquet in connection_methods.json
- Added the generation of @overload functions in the generation wrappers python code.
@dsevilla
Fix comment.
65e5e4d
@dsevilla
Fix comments again.
c37d493
@dsevilla
Merge branch 'main' into patch-1
b8bad33
@evertlammerts
Copy link
Collaborator

evertlammerts commented Sep 4, 2025

Thanks @dsevilla ! Can you target the v1.4-andium branch? We're preparing the 1.4.0 release, it's probably a good thing if this goes in?

@dsevilla dsevilla changed the base branch from main to v1.4-andium September 4, 2025 21:55
@dsevilla
Copy link
Contributor Author

dsevilla commented Sep 4, 2025

Of course! I just did that.

@evertlammerts evertlammerts merged commit 83d3f94 into duckdb:v1.4-andium Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistency in from_parquet and read_parquet wrt. file/glob list

2 participants

@dsevilla @evertlammerts