Skip to content

Add linting and formatting #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 100 commits into from
Sep 22, 2025
Merged

Add linting and formatting #72

merged 100 commits into from
Sep 22, 2025

Conversation

@evertlammerts
Copy link
Collaborator

@evertlammerts evertlammerts commented Sep 18, 2025

In this PR:

  • Using an extensive set of rules (see pyproject.toml), fixed lots and lots of linting errors with ruff
  • Added pre-commit as a dev dependency, with support for ruff, clang-format and cmake-format
  • Added a linting step to the on-pr job
  • Added the post-checkout hook as well that automatically updates the git submodule.

Soon:

  • add dev docs
  • plug into on-pr workflow
  • plug into nightly release workflow as sanity check (because why not: it's fast)

This is step 1 in fixing some of the devexp issues we have since v1.4.0.

See #62 #57 and #47

@evertlammerts
ruff conf: exclude pyi from linting
7d6f470
@evertlammerts
Ruff UP006: dont use typing module for dict and list typehints
db57889
@evertlammerts
Ruff ANN204: return type annotations
c23b65d
@evertlammerts
Ruff config: line-length to 120 and fixable no longer top level
83cdb9c
@evertlammerts
Ruff format fixes
d10c477
@evertlammerts
Ruff linter fixes
0ec0572
@evertlammerts
Ruff format fixes
c499e40
@evertlammerts
Ruff config: dont add future annotations
cde722e
@evertlammerts
Ruff config: temporarily skip import checks
89c6387
@evertlammerts
Ruff EM: Error messages assigned to a var first
6370653
@evertlammerts
Ruff D: Docstring fixes
6445bde
@evertlammerts
Ruff D301: Make docstring raw if they contain backslashes
2119fb0
@evertlammerts
Fix testfixture yield
b6fb52a
@evertlammerts
Ruff config: disable docstring checks for tests
4ff4147
@evertlammerts
Ruff noqa D205 on tests: no need to check newline between summary and
f983b69 
description in tests
@evertlammerts
Ruff noqa D205: dont need the newline in docstrings for existing code
12c0f48
@evertlammerts
Ruff config: will not check sqlogic
c0a94d2
@evertlammerts
Ruff config: will not check scripts for D
5cea343
@evertlammerts
Ruff noqa D10x: ignore docstring issues in existing code
a1675c8
@evertlammerts
Ruff config: F403 ignore * imports in pyspark tests
5a6deb4
@evertlammerts
Ruff F403: fix star imports
0041aab
@evertlammerts
Ruff format
ebe92af
@evertlammerts
Ruff linting fixes
7301a4d
@evertlammerts
Ruff F401: fixed unused imports
664c37b
@evertlammerts
Ruff config: disable ANN001 for tests and scripts, no need for type h…
f7930af 
…ints there
@evertlammerts
Ruff ANN001: fixed missing annotations for function args
63b902c
@evertlammerts
Ruff linting
a6e9d4e
@evertlammerts
Ruff format
25d3ab0
@evertlammerts
Ruff config: ANN201 no need for return value type hints in tests and …
6561517 
…scripts
@evertlammerts
Ruff ANN201: fixed return value type annotations
efe66bb
@evertlammerts
Ruff linting
11b0851
@evertlammerts
Ruff B: Fixed last bugbear linting issues
5ad0a0e
@evertlammerts
Ruff C416: use list() instead of comprehension where possible
7f0ff48
@evertlammerts
Ruff config: ignore C901, function complexity
7ad26fb
@evertlammerts
Ruff C408: rewrite dict() calls as literals
16fcbbc
@evertlammerts
Ruff C417: changed map() to comprehensions and generator where possible
d65d2b6
@evertlammerts
Ruff format
92a0698
@evertlammerts
Ruff ignore ANN002 and ANN003
c86008b
@evertlammerts
Ruff ANN: fixed remaining annotation linting issues
928b4f8
@evertlammerts
Fix tests
13d2e08
@evertlammerts
Ruff SIM: fixed all remaining simplify linting issues
7f3104b
@evertlammerts
Ruff RUF: fixed all remaining ruff specific linter issues
61ba166
@evertlammerts
Ruff ignore PERF for duckdb_packaging
a0e2b04
@evertlammerts
Ruff PERF: fixed all remaining performance linting issues
6de2ab7
@evertlammerts
Ruff format
1ee6b42
@evertlammerts
Ruff linting - remaining unsafe fixes
dc95538
@evertlammerts
Ruff linting - fixed all remaining issues
534bd76
@evertlammerts
Ruff format
4016ae1
@evertlammerts
Fixed test
bbac5a5
@evertlammerts
Added pre-commit
cd396c8
@evertlammerts
Added ruff and clang-format to pre-commit
bd2469f
@evertlammerts
Added cmake-format to pre-commit
9adacb5
@evertlammerts
Added post-checkout hook to pre-commit config
b9c1bd4
@evertlammerts
Run pre-commit on-push
c13599a
@evertlammerts
Very subtle typing problem in the tests
cdf0ee0
@evertlammerts evertlammerts mentioned this pull request Sep 18, 2025
Merged
@evertlammerts evertlammerts merged commit c96b325 into duckdb:v1.4-andium Sep 22, 2025
14 checks passed
@evertlammerts evertlammerts deleted the linting_etc branch September 22, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@evertlammerts