Which library is kmldom from?

[marklit]

This was run on Ubuntu 20 LTS.

$ sudo apt install ninja-build
$ git clone \
    --recurse-submodules https://github.com/duckdblabs/duckdb_spatial \
    ~/duckdb_spatial
$ cd ~/duckdb_spatial
$ GEN=ninja \
    make debug

...
[436/441] Linking CXX executable tools/sqlite3_api_wrapper/test_sqlite3_api_wrapper
FAILED: tools/sqlite3_api_wrapper/test_sqlite3_api_wrapper 
: && /usr/bin/c++ -g -g -O0 -DDEBUG -Wall    -fsanitize=undefined -fno-sanitize-recover=all -Wunused -Werror=vla -Wnarrowing -pedantic -rdynamic tools/sqlite3_api_wrapper/CMakeFiles/test_sqlite3_api_wrapper.dir/test/test_sqlite3_api_wrapper.cpp.o tools/sqlite3_api_wrapper/CMakeFiles/test_sqlite3_api_wrapper.dir/test/test_sqlite3_udf_api_wrapper.cpp.o -o tools/sqlite3_api_wrapper/test_sqlite3_api_wrapper  -Wl,-rpath,/home/mark/duckdb_spatial/build/debug/tools/sqlite3_api_wrapper:/home/mark/duckdb_spatial/build/debug/src:/home/mark/duckdb_spatial/build/debug/dependencies/local/lib  tools/sqlite3_api_wrapper/libsqlite3_api_wrapper.so  src/libduckdb.so  third_party/fsst/libduckdb_fsst.a  third_party/fmt/libduckdb_fmt.a  third_party/libpg_query/libduckdb_pg_query.a  third_party/re2/libduckdb_re2.a  third_party/miniz/libduckdb_miniz.a  third_party/utf8proc/libduckdb_utf8proc.a  third_party/hyperloglog/libduckdb_hyperloglog.a  third_party/fastpforlib/libduckdb_fastpforlib.a  third_party/mbedtls/libduckdb_mbedtls.a  extension/jemalloc/libjemalloc_extension.a  extension/spatial/libspatial_extension.a  dependencies/local/lib/libgdal.a  dependencies/local/lib/libgeos_c.a  dependencies/local/lib/libgeos.a  dependencies/local/lib/libproj.a  -lm  -ldl  dependencies/local/lib/libsqlite3.a  dependencies/local/lib/libcurl.a  dependencies/local/lib/libexpat.a  /usr/lib/x86_64-linux-gnu/libssl.a  /usr/lib/x86_64-linux-gnu/libcrypto.a  -ldl  dependencies/local/lib/libsqlite3.a  dependencies/local/lib/libz.so  dependencies/local/lib/libmemvfs.a  -lpthread && :
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::KmlFactory::CreateLinearRing() const'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::AsInnerBoundaryIs(boost::intrusive_ptr<kmldom::Element>)'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::KmlFactory::CreateCoordinates() const'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::AsOuterBoundaryIs(boost::intrusive_ptr<kmldom::Element>)'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::KmlFactory::CreateLinkSnippet() const'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::KmlFactory::CreateData() const'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::KmlFactory::CreateNetworkLink() const'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::KmlFactory::CreateScreenXY() const'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::AsContainer(boost::intrusive_ptr<kmldom::Element>)'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::KmlFactory::CreateLatLonAltBox() const'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::KmlFactory::CreateStyle() const'
/usr/bin/ld: src/libduckdb.so: undefined reference to `kmldom::AsPolygon(boost::intrusive_ptr<kmldom::Element>)'
...
/usr/include/boost/smart_ptr/intrusive_ptr.hpp:86: undefined reference to `kmlbase::intrusive_ptr_add_ref(kmlbase::Referent*)'
/usr/bin/ld: dependencies/local/lib/libgdal.a(ogrlibkmlfield.cpp.o): in function `boost::intrusive_ptr<kmldom::GxTimeSpan>::intrusive_ptr(kmldom::GxTimeSpan*, bool)':
/usr/include/boost/smart_ptr/intrusive_ptr.hpp:69: undefined reference to `kmlbase::intrusive_ptr_add_ref(kmlbase::Referent*)'
/usr/bin/ld: dependencies/local/lib/libgdal.a(ogrlibkmlfield.cpp.o):/usr/include/boost/smart_ptr/intrusive_ptr.hpp:69: more undefined references to `kmlbase::intrusive_ptr_add_ref(kmlbase::Referent*)' follow
/usr/bin/ld: dependencies/local/lib/libgdal.a(ogrlibkmlfeaturestyle.cpp.o): in function `kml2featurestyle(boost::intrusive_ptr<kmldom::Feature>, OGRLIBKMLDataSource*, OGRLayer*, OGRFeature*)':
/home/mark/duckdb_spatial/build/debug/dependencies/base/Source/GDAL/ogr/ogrsf_frmts/libkml/ogrlibkmlfeaturestyle.cpp:304: undefined reference to `kmldom::AsStyle(boost::intrusive_ptr<kmldom::Element>)'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
make: *** [Makefile:42: debug] Error 1

[Maxxen]

This is caused by GDAL finding libkml and enabling the driver, but we don't link it in in the final build. We need to make sure we disable all optional drivers.

[marklit]

How would I go about disabling it?

[Maxxen]

I would put: -DGDAL_USE_LIBKML=OFF here:

https://github.com/duckdblabs/duckdb_spatial/blob/260e847d4d66dd1e8863124a539ffa7c657d907e/spatial/dependencies/CMakeLists.txt#L173

[marklit]

The works, thank you.

diff --git a/spatial/dependencies/CMakeLists.txt b/spatial/dependencies/CMakeLists.txt
index 9056280..01ef008 100644
--- a/spatial/dependencies/CMakeLists.txt
+++ b/spatial/dependencies/CMakeLists.txt
@@ -170,7 +170,7 @@ ExternalProject_Add(
     -DGDAL_USE_CURL=ON
     -DGDAL_USE_OPENSSL=ON
     -DOPENSSL_USE_STATIC_LIBS=ON # Propagate to FindOpenSSL.cmake
-
+    -DGDAL_USE_LIBKML=OFF
     # This is not true, but a bug in gdal's cmake files
     -DACCEPT_MISSING_SQLITE3_RTREE:BOOL=ON
     -DACCEPT_MISSING_SQLITE3_MUTEX_ALLOC:BOOL=ON

$ GEN=ninja \
    make release