-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Experiment with enabling prompted Fireproofing by default #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmonfortep
merged 23 commits into
develop
from
feature/cristian/experiment_login_enabled
Feb 16, 2021
Merged
Experiment with enabling prompted Fireproofing by default #1097
cmonfortep
merged 23 commits into
develop
from
feature/cristian/experiment_login_enabled
Feb 16, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce fireproof prompt
CDRussell
approved these changes
Feb 12, 2021
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All scenarios tested and working well on Pixel 2 running latest Android; functionality as expected and pixels as expected. I'm having problems getting a reliable emulator to test out on Lollipop, so my testing is less thorough there - just FYI.
# Conflicts: # app/src/main/java/com/duckduckgo/app/browser/di/BrowserModule.kt # app/src/main/res/values/string-untranslated.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1199920127722390/f
Tech Design URL: https://app.asana.com/0/1142021229838617/1199920405912714/f
CC:
Description:
We want to run an experiment to measure the effect of enabling Fireproof login detection by default.
Control group: no changes.
Experimental variant: we've introduced the following product changes:
Steps to test this PR:
Control group:
Experiment Test 1: when Login dialog dismissed twice in a row, ask user to disable login detection
Experiment Test 2: we ask to disable login detection only once
Experiment Test 3: if user enables login detection, never ask them to disable login detection
Experiment Test 4: Validate pixels (user did not try the fire button)
m_fw_ld_swithfe=falsem_fw_l_dwithfe=falsem_fw_dd_swithfe=falsem_fw_dd_cwithfe=falsem_fw_l_awithfe=falsesentExperiment Test 5: Validate pixels (user already tried the fire button)
m_fw_ld_swithfe=truem_fw_l_dwithfe=truem_fw_dd_swithfe=truem_fw_dd_cwithfe=truem_fw_l_awithfe=truesentInternal references:
Software Engineering Expectations
Technical Design Template