Release Fireproof login detection #1137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1200078998119893/f
Tech Design URL:
CC: https://app.asana.com/0/1142021229838617/1200081522320196/f
Description:
We decided to release to all users Fireproof login detection enabled by default (#1097).
This PR removes experimental variants of our login detection experiment.
Changes:
Steps to test this PR:
Optional test cases (we haven't introduced any change in our login detection logic, I'm copying here the most important ones from #1097):
Test 1: when Login dialog dismissed twice in a row, ask user to disable login detection
Experiment Test 2: we ask to disable login detection only once
Internal references:
Software Engineering Expectations
Technical Design Template