Skip to content

Conversation

@cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Mar 18, 2021

Task/Issue URL: https://app.asana.com/0/488551667048375/1200078998119893/f
Tech Design URL:
CC: https://app.asana.com/0/1142021229838617/1200081522320196/f

Description:
We decided to release to all users Fireproof login detection enabled by default (#1097).
This PR removes experimental variants of our login detection experiment.

Changes:

  • login detection enabled by default to all users
  • removed variants
  • copy translations

Steps to test this PR:

  1. Fresh install
  2. Open the browser
  3. Go to settings, ensure login detection is enabled by default

Optional test cases (we haven't introduced any change in our login detection logic, I'm copying here the most important ones from #1097):

Test 1: when Login dialog dismissed twice in a row, ask user to disable login detection

  1. Fresh intall
  2. Go to settings and ensure login detection is enabled
  3. Go back to the browser
  4. Perform login in two different websites, and dismiss the Fireproof login dialog in all of them
  5. Ensure dialog asking to disable login detection shown
  6. Press disable
  7. Go to fireproof settings and ensure login detection is disabled

Experiment Test 2: we ask to disable login detection only once

  1. Fresh intall
  2. Perform login in two different websites, and dismiss the Fireproof login dialog in all of them
  3. Ensure dialog asking to disable login detection shown
  4. Press "Cancel"
  5. Clear all data (this is optional, clear data so we can login on sites again)
  6. Perform login in two different websites, and dismiss the Fireproof login dialog in all of them
  7. Ensure we don't show again the dialog to disable login detection

Internal references:

Software Engineering Expectations
Technical Design Template

@cmonfortep cmonfortep marked this pull request as ready for review March 19, 2021 14:13
@cmonfortep
Copy link
Contributor Author

@CDRussell this is ready to review, but it can't be merged yet (because of translations). Translations are still in progress in Smartling, I will push them here once they are ready.

Copy link
Member

@CDRussell CDRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tested and working as expected.

@cmonfortep
Copy link
Contributor Author

@CDRussell, I've just merged translations here and I did a check on different languages. Everything good. I will merge it once checks are green.

@cmonfortep cmonfortep merged commit dbd43b7 into develop Mar 24, 2021
@cmonfortep cmonfortep deleted the feature/cristian/release_fireproof_exp branch March 24, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants