fix: convert clip data into plain text before pasting to omnibar

[hotchemi]

Task/Issue URL: #1074

Description:

• This PR modifies KeyboardAwareEditText to be aware of pasting text from the clipboard and clear its style beforehand.
  • If API level >= M, we can just use R.id.pasteAsPlainText
  • If API level < M, we need to manually clear and set the data to primary clip again(see ClipboardManager.convertClipToPlainText)

Discussion

• Now KeyboardAwareEditText has kind of two responsibilities and I was thinking I should rename the class as OmniToolbarEditText or something, but since this is my 1st PR as an external contributor I'd like to keep the diff smaller as much as I can. Let me know your thoughts around here🙏

Steps to test this PR:

1. API level >= M

• Launch the emulator with API Level M
• Open https://www.theverge.com/2018/1/23/16922508/private-search-engine-duckduckgo-browser-extension-app
• Copy bold "DuckDuckGo" from the title
• Paste the clipboard clip to omnibar search input area
• Confirm there's no rich text formatting

2. API level < M

• Launch the emulator with API Level M
• Open https://www.theverge.com/2018/1/23/16922508/private-search-engine-duckduckgo-browser-extension-app
• Copy bold "DuckDuckGo" from the title
• Paste the clipboard clip to omnibar search input area
• Confirm there's no rich text formatting

Screenshots

API level >= M

Before	After

API level < M

Before	After

---

Internal references:

Software Engineering Expectations
Technical Design Template

[cmonfortep]

Thanks, we will take a look as soon as possible.

[malmstein]

Thanks for the submission @hotchemi. This is indeed very helpful and fixes an issue, good job!

On the actual code:

1. How do you feel about not using extension functions? We don't really need this feature anywhere else and I'd prefer if the convertClipToPlainText function would only be known to the KeyboardEditText
2. On the naming of the EditText itself, we are working on a few things internally that will change its behavior, so it's better not to change anything else just yet.

[hotchemi]

@malmstein Thank you for the quick review!

• RE: 1 I'm fine with your suggestion and let me make my aim clear just in case🙏 My intention here for using Kotlin's extension function is to provide a more readable way to define logic and actually those extensions are not available outside of KeyboardAwareEditText(because those are private, which I've occasionally seen in Kotlin repo)🙇

• RE: 2 Copy that!

[malmstein]

@hotchemi thanks for clarifying, I completely missed the private on the extension functions declaration! It actually reads quite nice and I'm happy with it.

Thanks for the contribution!

[malmstein]

Happy with the changes because the extension functions are private to the View

[hotchemi]

Thank you so much for your review😄🙏